PE rich signature improvements #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of the matching rich entries instead of a boolean It remains backwards compatible thanks to non-null values being considered as true and when not found it returns 0 (false).
to reflect changes of behavior: it now returns the sum of counts matching to given `toolid` and `version`.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Note regarding CLA: I'm in the process of getting the corporate CLA signed, it should be done shortly. |
|
@googlebot I signed it! |
tarterp
pushed a commit
to mandiant/yara
that referenced
this pull request
Mar 31, 2022
* rich_internal function now returns the sum of counts of the matching rich entries instead of a boolean It remains backwards compatible thanks to non-null values being considered as true and when not found it returns 0 (false). * Update documentation of the `toolid` and `version` in PE module to reflect changes of behavior: it now returns the sum of counts matching to given `toolid` and `version`. * Added test for the updated rich_signature function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
pe.rich_signature.toolidandpe.rich_signature.versionfunctions to return the sum of "count values" in the Rich header for the given tool id and/or tool version.Although it changes the behavior of the functions, it should be backward compatible with existing YARA rules. If there's a match the count should be more than 0, which will evaluates to
truewhen converted to boolean. The only case where it wouldn't work is if the YARA rule compares the boolean return value with1.Test was added and doc was updated to reflect the change.