CI caching #50
Merged
CI caching #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelLipski
reviewed
Aug 11, 2020
.travis.yml
Outdated
| - $HOME/.sbt | ||
|
|
||
| before_cache: | ||
| # Cleanup the cached directories to avoid unnecessary cache updates |
There was a problem hiding this comment.
Hmm maybe just delete all the contents of ~/.ivy2/cache and ~/.sbt ... why just specifically these files? 🤔
There was a problem hiding this comment.
If not, then include the reason for only removing *.properties/*.lock in the comment
There was a problem hiding this comment.
It seems that it doesn't really matter.
The original comes from here: https://www.scala-sbt.org/0.13/docs/Travis-CI-with-sbt.html#Caching
There is no explanation though.
Here is an example of the way you suggested: typelevel/cats#2158
and I quote: seems marginally faster, or at least not slower, and it is also simpler.
So for the sake of simplicity lets remove before_cache section
PawelLipski
reviewed
Aug 11, 2020
| @@ -57,7 +68,7 @@ script: | |||
| # -batch is necessary to make sure sbt doesn't stall waiting for user input in case of certain failures | |||
| - echo '-batch' >> .sbtopts | |||
| - sbt scalafmtCheck | |||
| - sbt compile test | |||
| - sbt compile | |||
PawelLipski
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.