Skip to content

Skip using Scala nightlies in unit tests when they can't be fetched #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Gedochao
Copy link
Contributor

This should fix the CI failing on main:

scala.build.tests.BuildOptionsTests:
==> X scala.build.tests.BuildOptionsTests.initializationError  0.001s java.lang.UnsupportedOperationException: empty.maxBy
    at scala.collection.IterableOnceOps.maxBy(IterableOnce.scala:1160)
    at scala.collection.IterableOnceOps.maxBy$(IterableOnce.scala:1158)
    at scala.collection.AbstractIterable.maxBy(Iterable.scala:935)
    at scala.build.tests.BuildOptionsTests.<init>(BuildOptionsTests.scala:333)
    at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
    at java.lang.reflect.ReflectAccess.newInstance(ReflectAccess.java:128)
    at jdk.internal.reflect.ReflectionFactory.newInstance(ReflectionFactory.java:347)
    at java.lang.Class.newInstance(Class.java:645)
    at munit.MUnitRunner.MUnitRunner$superArg$1$$anonfun$1(MUnitRunner.scala:32)
    at munit.MUnitRunner.<init>(MUnitRunner.scala:34)
    at munit.MUnitRunner.<init>(MUnitRunner.scala:32)
    at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:481)
    at munit.internal.junitinterface.JUnitComputer.getRunner(JUnitComputer.java:75)
    at munit.internal.junitinterface.JUnitComputer$1.runnerForClass(JUnitComputer.java:65)
    ...

https://github.com/VirtusLab/scala-cli/actions/runs/13280636786/job/37078168991#step:8:701

@Gedochao Gedochao force-pushed the maintenance/fix-nightlies-failing-unit-tests branch from 5b93dc7 to de750e1 Compare February 12, 2025 09:10
@tgodzik tgodzik merged commit 72988e3 into VirtusLab:main Feb 12, 2025
16 of 55 checks passed
@Gedochao Gedochao deleted the maintenance/fix-nightlies-failing-unit-tests branch February 12, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants