Skip to content

Deprecate --src and --sources to disambiguate with --source compiler option #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

Gedochao
Copy link
Contributor

Follow-up to #3257 (comment)

What it does

  • deprecates --src and --sources aliases for the package sub-command command line option for generating sources jars
  • deprecates --sources for the publish sub-command line option for including sources jars while publishing
  • adds matching aliases for the publish option, to be consistent with package
  • adds a new --with-sources alias, which now becomes the default and recommended syntax
  • --src and --sources should be removed in 1.7.0 or later
  • other aliases (--sources-jar, --jar-sources) remain unchanged
  • this is done to disambiguate with the --source compiler option

@Gedochao Gedochao requested a review from tgodzik January 10, 2025 12:56
@Gedochao Gedochao force-pushed the maintenance/deprecate-src branch from 601ef67 to 768d46d Compare January 10, 2025 15:12
@Gedochao Gedochao force-pushed the maintenance/deprecate-src branch from 768d46d to 1cddcbf Compare January 10, 2025 16:04
@Gedochao Gedochao enabled auto-merge (squash) January 10, 2025 16:04
@Gedochao Gedochao merged commit f03676e into VirtusLab:main Jan 13, 2025
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants