-
Notifications
You must be signed in to change notification settings - Fork 140
Change how help is referenced to avoid initialization oddness & update case-app
to 2.1.0-M29
#3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how help is referenced to avoid initialization oddness & update case-app
to 2.1.0-M29
#3152
Conversation
Did some fixes:
What's still breaking:
|
8d34bd6
to
b2ce3f7
Compare
Seems it was just whitespace that changed in the fish completions file generation, unsure what is causing this. @tgodzik can you verify |
case-app
to 2.1.0-M29
...s/integration/src/test/scala/scala/cli/integration/InstallAndUninstallCompletionsTests.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coreyoconnor I tweaked the PR to make the tests pass, hope you don't mind.
Thanks for helping with this!
Woohoo! Thanks! Obviously I was away and only getting back to this now. XD Happy to help! |
This includes the update for
case-app
.This supersedes pull #2964
Draft because I don't really understand why this only effected some options and not others and why only with this version of case app. That said...
scala-cli
overridesval messages
. This override referencesname
which is adef
inCaseApp
equal tohelp.progName
. Which is equal tomessages.progName
. Which is theval messages
being defined. I'm not entirely sure on that last bit but I suspect Scala is not entirely sure as well. :)Breaking these recursive dependencies appears to work. That's what this patch tries to do.
I suspect there is an issue in how
CaseApp
is constructed. Or perhapsdef help
should be overriden instead ofval messages
.