Skip to content

Update action to use node 20 #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
{
"plugins": [
"@typescript-eslint"
],
"plugins": ["@typescript-eslint"],
"extends": [
"plugin:github/recommended"
"plugin:github/typescript"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module",
"project": "./tsconfig.json"
"project": true
},
"rules": {
"eslint-comments/no-use": "off",
Expand All @@ -34,10 +32,7 @@
"allowExpressions": true
}
],
"@typescript-eslint/func-call-spacing": [
"error",
"never"
],
"@typescript-eslint/func-call-spacing": ["error", "never"],
"@typescript-eslint/no-array-constructor": "error",
"@typescript-eslint/no-empty-interface": "error",
"@typescript-eslint/no-explicit-any": "warn",
Expand All @@ -59,10 +54,7 @@
"@typescript-eslint/require-array-sort-compare": "error",
"@typescript-eslint/restrict-plus-operands": "error",
"semi": "off",
"@typescript-eslint/semi": [
"error",
"never"
],
"@typescript-eslint/semi": ["error", "never"],
"@typescript-eslint/type-annotation-spacing": "error",
"@typescript-eslint/unbound-method": "error",
"i18n-text/no-en": "off"
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '20'
cache: 'npm'
- name: Build
shell: bash -l {0}
run: |
nvm install lts/gallium
nvm use lts/gallium
npm install
npm ci
npm run all

# create an sbt file to enabling sbt caching
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/update-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ jobs:
- uses: actions/checkout@v4
with:
ssh-key: ${{ secrets.SCALA_CLI_SETUP_INTERNAL_KEY }}
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '20'
cache: 'npm'
- name: Build
shell: bash -l {0}
run: |
nvm install lts/gallium
nvm use lts/gallium
npm install
npm ci
npm run all

- name: Create Pull Request
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ outputs:
scala-cli-version:
description: 'Version of the installed Scala CLI'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
Loading