Skip to content

feat: 821 start settings menu#822

Merged
kjy5 merged 2 commits intodevelopfrom
821-start-settings-menu
Sep 10, 2025
Merged

feat: 821 start settings menu#822
kjy5 merged 2 commits intodevelopfrom
821-start-settings-menu

Conversation

@kjy5
Copy link
Member

@kjy5 kjy5 commented Sep 10, 2025

No description provided.

@kjy5 kjy5 requested a review from Copilot September 10, 2025 22:50
@kjy5 kjy5 linked an issue Sep 10, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a settings menu for the application by adding a new Settings dialog accessible through the main UI. The changes introduce a tabbed settings interface with an EphysLink configuration panel.

  • Adds a new Settings.uxml view with tabbed interface structure
  • Integrates the settings dialog into the main UI with a gear icon button
  • Updates the main view to include settings template and dialog trigger
  • Removes unused code from MainViewModel related to scene state subscription

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

File Description
Assets/UI/Views/Settings.uxml Creates new settings view with tabs and EphysLink configuration panel
Assets/UI/Main.uxml Integrates settings dialog trigger and template into main UI layout
Assets/Scripts/UI/Views/MainView.cs Removes unused UnityEngine import in favor of conditional compilation
Assets/Scripts/UI/ViewModels/MainViewModel.cs Cleans up unused scene state subscription references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kjy5 kjy5 merged commit c23aa5c into develop Sep 10, 2025
@kjy5 kjy5 deleted the 821-start-settings-menu branch September 10, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start settings menu

1 participant