Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements probe creation and removal functionality with basic movement controls via keyboard and dragging. The changes introduce a new UI system for managing probes through dropdown menus and list views, while consolidating probe type definitions and updating the Redux state management to handle probe operations.
- Adds probe creation UI with dropdown menus for different probe types (Neuropixels, Pipettes, UCLA)
- Implements probe removal functionality with delete buttons in the probe list
- Consolidates
ProbeTypeenum fromProbePropertiesto a shared utilities location and updates all references
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ProjectSettings/ProjectSettings.asset | Enables APP_UI directive for new UI system |
| Assets/UI/Views/Scene.uxml | Adds probe creation menu and updates probe list view |
| Assets/UI/Styles/ProbeColors.uss | Defines CSS color variables and classes for probe icons |
| Assets/UI/Components/ProbeListItem.uxml | Updates probe list item component with new UI elements |
| Assets/Scripts/UI/Views/SceneView.cs | Implements probe creation/selection event handlers |
| Assets/Scripts/UI/Views/ProbeListItemView.cs | Handles probe list item interactions and color management |
| Assets/Scripts/UI/Views/MainView.cs | Updates UI visibility logic for APP_UI directive |
| Assets/Scripts/UI/ViewModels/SceneViewModel.cs | Adds probe management commands and state subscriptions |
| Assets/Scripts/UI/ViewModels/ProbeListItemViewModel.cs | View model for individual probe list items |
| Assets/Scripts/Services/StoreService.cs | Updates Redux action registration |
| Assets/Scripts/Pinpoint/ | Multiple files updating ProbeType references |
| Assets/Scripts/Models/Scene/ | Updates Redux reducers and actions for probe management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Assets/Scripts/Pinpoint/Probes/Controllers/CartesianProbeController.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And basic movement with keyboard and dragging (no axis lines)