Skip to content

feat: 814 probe creation and removal#815

Merged
kjy5 merged 11 commits intodevelopfrom
814-probe-creation-and-removal
Sep 4, 2025
Merged

feat: 814 probe creation and removal#815
kjy5 merged 11 commits intodevelopfrom
814-probe-creation-and-removal

Conversation

@kjy5
Copy link
Member

@kjy5 kjy5 commented Sep 4, 2025

And basic movement with keyboard and dragging (no axis lines)

@kjy5 kjy5 requested a review from Copilot September 4, 2025 23:53
@kjy5 kjy5 linked an issue Sep 4, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements probe creation and removal functionality with basic movement controls via keyboard and dragging. The changes introduce a new UI system for managing probes through dropdown menus and list views, while consolidating probe type definitions and updating the Redux state management to handle probe operations.

  • Adds probe creation UI with dropdown menus for different probe types (Neuropixels, Pipettes, UCLA)
  • Implements probe removal functionality with delete buttons in the probe list
  • Consolidates ProbeType enum from ProbeProperties to a shared utilities location and updates all references

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ProjectSettings/ProjectSettings.asset Enables APP_UI directive for new UI system
Assets/UI/Views/Scene.uxml Adds probe creation menu and updates probe list view
Assets/UI/Styles/ProbeColors.uss Defines CSS color variables and classes for probe icons
Assets/UI/Components/ProbeListItem.uxml Updates probe list item component with new UI elements
Assets/Scripts/UI/Views/SceneView.cs Implements probe creation/selection event handlers
Assets/Scripts/UI/Views/ProbeListItemView.cs Handles probe list item interactions and color management
Assets/Scripts/UI/Views/MainView.cs Updates UI visibility logic for APP_UI directive
Assets/Scripts/UI/ViewModels/SceneViewModel.cs Adds probe management commands and state subscriptions
Assets/Scripts/UI/ViewModels/ProbeListItemViewModel.cs View model for individual probe list items
Assets/Scripts/Services/StoreService.cs Updates Redux action registration
Assets/Scripts/Pinpoint/ Multiple files updating ProbeType references
Assets/Scripts/Models/Scene/ Updates Redux reducers and actions for probe management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kjy5 kjy5 merged commit 2965d7b into develop Sep 4, 2025
@kjy5 kjy5 deleted the 814-probe-creation-and-removal branch September 4, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Probe creation and removal

1 participant