Skip to content

Commit

Permalink
feat: Drop buttons tooltips specific to guests.
Browse files Browse the repository at this point in the history
  • Loading branch information
damencho committed Nov 6, 2020
1 parent 4fdd4b6 commit c2539bf
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 26 deletions.
3 changes: 0 additions & 3 deletions lang/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@
"kickTitle": "Ouch! {{participantDisplayName}} kicked you out of the meeting",
"liveStreaming": "Live Streaming",
"liveStreamingDisabledBecauseOfActiveRecordingTooltip": "Not possible while recording is active",
"liveStreamingDisabledForGuestTooltip": "Guests can't start live streaming.",
"liveStreamingDisabledTooltip": "Start live stream disabled.",
"lockMessage": "Failed to lock the conference.",
"lockRoom": "Add meeting $t(lockRoomPasswordUppercase)",
Expand Down Expand Up @@ -255,7 +254,6 @@
"readMore": "more",
"recording": "Recording",
"recordingDisabledBecauseOfActiveLiveStreamingTooltip": "Not possible while a live stream is active",
"recordingDisabledForGuestTooltip": "Guests can't start recordings.",
"recordingDisabledTooltip": "Start recording disabled.",
"rejoinNow": "Rejoin now",
"remoteControlAllowedMessage": "{{user}} accepted your remote control request!",
Expand Down Expand Up @@ -287,7 +285,6 @@
"shareVideoTitle": "Share a video",
"shareYourScreen": "Share your screen",
"shareYourScreenDisabled": "Screen sharing disabled.",
"shareYourScreenDisabledForGuest": "Guests can't screen share.",
"startLiveStreaming": "Start live stream",
"startRecording": "Start recording",
"startRemoteControlErrorMessage": "An error occurred while trying to start the remote control session!",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,7 @@ export function _mapStateToProps(state: Object, ownProps: Props) {
if (!visible && !_disabled) {
_disabled = true;
visible = true;

// button and tooltip
if (state['features/base/jwt'].isGuest) {
_tooltip = 'dialog.liveStreamingDisabledForGuestTooltip';
} else {
_tooltip = 'dialog.liveStreamingDisabledTooltip';
}
_tooltip = 'dialog.liveStreamingDisabledTooltip';
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,7 @@ export function _mapStateToProps(state: Object, ownProps: Props): Object {
if (!visible && !_disabled) {
_disabled = true;
visible = true;

// button and tooltip
if (state['features/base/jwt'].isGuest) {
_tooltip = 'dialog.recordingDisabledForGuestTooltip';
} else {
_tooltip = 'dialog.recordingDisabledTooltip';
}
_tooltip = 'dialog.recordingDisabledTooltip';
}
}
}
Expand Down
10 changes: 1 addition & 9 deletions react/features/toolbox/components/web/Toolbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -1426,15 +1426,7 @@ function _mapStateToProps(state) {
desktopSharingEnabled = getParticipants(state)
.find(({ features = {} }) =>
String(features['screen-sharing']) === 'true') !== undefined;

// we want to show button and tooltip
if (state['features/base/jwt'].isGuest) {
desktopSharingDisabledTooltipKey
= 'dialog.shareYourScreenDisabledForGuest';
} else {
desktopSharingDisabledTooltipKey
= 'dialog.shareYourScreenDisabled';
}
desktopSharingDisabledTooltipKey = 'dialog.shareYourScreenDisabled';
}

// NB: We compute the buttons again here because if URL parameters were used to
Expand Down

0 comments on commit c2539bf

Please sign in to comment.