Skip to content

Commit

Permalink
fix(suboptimal): allow checks for chromium based browsers
Browse files Browse the repository at this point in the history
  • Loading branch information
Leonard Kim authored and virtuacoplenny committed Jun 21, 2019
1 parent 243fdba commit 1e39c12
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions interface_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ var interfaceConfig = {
// Names of browsers which should show a warning stating the current browser
// has a suboptimal experience. Browsers which are not listed as optimal or
// unsupported are considered suboptimal. Valid values are:
// chrome, edge, electron, firefox, nwjs, opera, safari
OPTIMAL_BROWSERS: [ 'chrome', 'firefox', 'nwjs', 'electron' ],
// chrome, chromium, edge, electron, firefox, nwjs, opera, safari
OPTIMAL_BROWSERS: [ 'chrome', 'chromium', 'firefox', 'nwjs', 'electron' ],

// Browsers, in addition to those which do not fully support WebRTC, that
// are not supported and should show the unsupported browser page.
Expand Down
1 change: 1 addition & 0 deletions react/features/base/environment/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const DEFAULT_UNSUPPORTED_BROWSERS = [];

const browserNameToCheck = {
chrome: browser.isChrome.bind(browser),
chromium: browser.isChromiumBased.bind(browser),
edge: browser.isEdge.bind(browser),
electron: browser.isElectron.bind(browser),
firefox: browser.isFirefox.bind(browser),
Expand Down

0 comments on commit 1e39c12

Please sign in to comment.