Skip to content

VCST-3865: pickup locations index #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

VCST-3865: pickup locations index #61

wants to merge 25 commits into from

Conversation

@yuskithedeveloper
Copy link
Contributor

@yuskithedeveloper yuskithedeveloper commented Oct 10, 2025 •
edited by vc-ci
Loading

vc-ci
vc-ci reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.004
Timestamp: 10-10-2025T16:56:22

vc-ci
vc-ci reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.504
Timestamp: 10-10-2025T18:59:06

vc-ci
vc-ci reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.916
Timestamp: 10-10-2025T19:30:57

vc-ci
vc-ci reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.105
Timestamp: 10-10-2025T20:26:08

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.547
Timestamp: 13-10-2025T12:55:59

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.405
Timestamp: 13-10-2025T13:05:32

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.795
Timestamp: 13-10-2025T13:55:30

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.454
Timestamp: 13-10-2025T17:25:12

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.432
Timestamp: 13-10-2025T19:22:49

vc-ci
vc-ci reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.621
Timestamp: 13-10-2025T20:25:56

vc-ci
vc-ci reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.89
Timestamp: 15-10-2025T15:47:43

vc-ci
vc-ci reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.759
Timestamp: 15-10-2025T15:57:33

@yuskithedeveloper yuskithedeveloper marked this pull request as ready for review October 15, 2025 17:24
@cursor
Copy link

cursor bot commented Oct 15, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 11.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursor[bot]

This comment was marked as outdated.

Sign in to view

vc-ci
vc-ci reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.379
Timestamp: 23-10-2025T18:15:09

vc-ci
vc-ci reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.719
Timestamp: 23-10-2025T18:24:49

vc-ci
vc-ci reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.46
Timestamp: 23-10-2025T18:34:24

cursor[bot]

This comment was marked as outdated.

Sign in to view

artem-dudarev
artem-dudarev previously approved these changes Oct 28, 2025
View reviewed changes
vc-ci
vc-ci reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.803
Timestamp: 30-10-2025T17:06:24

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cursor[bot]
cursor bot reviewed Oct 30, 2025
View reviewed changes
src/VirtoCommerce.ShippingModule.Web/Controllers/Api/PickupLocationsController.cs

[HttpGet]
[Route("indexedSearchEnabled")]
public ActionResult GetOrderFullTextSearchEnabled()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Misleading Method Name for Pickup Search

The GetOrderFullTextSearchEnabled() method's name is misleading; it returns the enablement status for pickup location full-text search, not order full-text search.

Fix in Cursor Fix in Web

vc-ci
vc-ci reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.472
Timestamp: 30-10-2025T17:48:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vc-ci vc-ci vc-ci left review comments

@cursor cursor[bot] cursor[bot] left review comments

@artem-dudarev artem-dudarev artem-dudarev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuskithedeveloper @artem-dudarev @vc-ci