Skip to content

Fixed variation binding to support the Lucene search engine when prod… #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fixed variation binding to support the Lucene search engine when prod… #571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb3e54
Fixed variation binding to support the Lucene search engine when prod…
IgorisB Oct 28, 2024
3b705a3
Merge branch 'dev' into fix-variationbinding
IgorisB Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/VirtoCommerce.ExperienceApiModule.DigitalCatalog/Binding/VariationsBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Collections.Generic;
using System.Linq;
using VirtoCommerce.ExperienceApiModule.Core.Binding;
using VirtoCommerce.SearchModule.Core.Model;
Expand All @@ -10,11 +11,19 @@ public class VariationsBinder : IIndexModelBinder

public virtual object BindModel(SearchDocument searchDocument)
{
var fieldName = BindingInfo.FieldName;
if (!searchDocument.TryGetValue(BindingInfo.FieldName, out var value))
{
return new List<string>();
}

return searchDocument.ContainsKey(fieldName) && searchDocument[fieldName] is object[] objs
? objs.Select(x => (string)x).ToList()
: Enumerable.Empty<string>().ToList();
// It is important to note that not all search engines, such as Lucene, support field types as collections,
// so they may not return an array for single value
return value switch
{
IEnumerable<object> objs => objs.Select(x => x.ToString()).ToList(),
string s => [s],
_ => []
};
}
}
}
Loading