Skip to content

Conversation

@mihey8800
Copy link

@mihey8800 mihey8800 commented Oct 23, 2025

Description

provider fully overridable. protected methods added to all public methods

References

QA-test:

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.ElasticSearch8_3.822.0-alpha.141-protected-provider.zip

@vc-ci
Copy link
Contributor

vc-ci commented Oct 23, 2025

Review task created: https://virtocommerce.atlassian.net/browse/VCST-4180

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Missing Virtual Keyword in Method

The InternalAddActiveAlias method is missing the virtual keyword. This makes it non-overridable, which is inconsistent with other Internal methods and prevents derived classes from fully extending the provider as intended.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Missing Virtual Keyword in Internal Method

The InternalAddActiveAlias method is missing the virtual keyword. This makes it inconsistent with other Internal* methods and prevents overriding in subclasses, which goes against the goal of a fully overridable provider.

Fix in Cursor Fix in Web

@OlegoO OlegoO requested a review from alexeyshibanov October 23, 2025 10:39
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.455
Timestamp: 23-10-2025T10:35:14

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.323
Timestamp: 23-10-2025T10:44:51

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.156
Timestamp: 23-10-2025T11:51:24

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.961
Timestamp: 23-10-2025T12:04:41

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.727
Timestamp: 23-10-2025T12:40:53

@mihey8800 mihey8800 requested a review from OlegoO October 29, 2025 11:56
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.663
Timestamp: 29-10-2025T11:58:28

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.592
Timestamp: 29-10-2025T15:15:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants