Skip to content

Conversation

@basilkot
Copy link
Contributor

@basilkot basilkot commented Sep 27, 2025

@basilkot basilkot requested a review from Copilot September 27, 2025 16:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where published files were being removed when users made changes, implementing proper draft/published file state management. The changes include new tests for publishing service functionality, updates to the publishing service implementation, and modifications to content controllers to properly handle file states.

  • Adds comprehensive test coverage for publishing service with various draft/published scenarios
  • Updates the publishing service to properly handle file naming and status updates
  • Modifies content controller to use dependency injection instead of private fields

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
PublishingServiceTests.cs New comprehensive test suite covering publishing service functionality
ContentStatisticServiceTests.cs New test suite for content statistics service
page-detail.js Updates published state tracking in UI
ContentController.cs Refactors to use dependency injection and fixes file status handling
PublishingService.cs Improves draft suffix removal and file URL handling
ContentStatisticService.cs Updates to use publishing service for proper file counting
DocumentIdentifierHelper.cs Minor syntax modernization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.594
Timestamp: 27-09-2025T16:42:38

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.532
Timestamp: 27-09-2025T18:27:00

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.527
Timestamp: 29-09-2025T10:19:31

OlegoO
OlegoO previously approved these changes Sep 29, 2025
artem-dudarev
artem-dudarev previously approved these changes Sep 29, 2025
@basilkot basilkot dismissed stale reviews from artem-dudarev and OlegoO via d2b4837 September 29, 2025 13:19
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.697
Timestamp: 29-09-2025T13:28:12

artem-dudarev
artem-dudarev previously approved these changes Sep 29, 2025
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.942
Timestamp: 30-09-2025T11:31:35

@sonarqubecloud
Copy link

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.263
Timestamp: 30-09-2025T14:20:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants