-
Couldn't load subscription status.
- Fork 9
VCST-3904: Published file should not be removed when user makes changes #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses an issue where published files were being removed when users made changes, implementing proper draft/published file state management. The changes include new tests for publishing service functionality, updates to the publishing service implementation, and modifications to content controllers to properly handle file states.
- Adds comprehensive test coverage for publishing service with various draft/published scenarios
- Updates the publishing service to properly handle file naming and status updates
- Modifies content controller to use dependency injection instead of private fields
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| PublishingServiceTests.cs | New comprehensive test suite covering publishing service functionality |
| ContentStatisticServiceTests.cs | New test suite for content statistics service |
| page-detail.js | Updates published state tracking in UI |
| ContentController.cs | Refactors to use dependency injection and fixes file status handling |
| PublishingService.cs | Improves draft suffix removal and file URL handling |
| ContentStatisticService.cs | Updates to use publishing service for proper file counting |
| DocumentIdentifierHelper.cs | Minor syntax modernization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/VirtoCommerce.ContentModule.Data/Services/PublishingService.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ContentModule.Data/Services/PublishingService.cs
Outdated
Show resolved
Hide resolved
tests/VirtoCommerce.ContentModule.Tests/PublishingServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.594
Timestamp: 27-09-2025T16:42:38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.532
Timestamp: 27-09-2025T18:27:00
src/VirtoCommerce.ContentModule.Data/Services/ContentStatisticService.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ContentModule.Data/Services/PublishingService.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ContentModule.Data/Services/ContentStatisticService.cs
Outdated
Show resolved
Hide resolved
tests/VirtoCommerce.ContentModule.Tests/ContentStatisticServiceTests.cs
Outdated
Show resolved
Hide resolved
tests/VirtoCommerce.ContentModule.Tests/PublishingServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.527
Timestamp: 29-09-2025T10:19:31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.697
Timestamp: 29-09-2025T13:28:12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.942
Timestamp: 30-09-2025T11:31:35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.263
Timestamp: 30-09-2025T14:20:19



Description
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-3904
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Content_3.829.0-pr-200-6dd0.zip