Skip to content

Conversation

@eMazeika
Copy link

@eMazeika eMazeika requested review from akak1977 and tatarincev May 20, 2020 09:08
@vc-ci
Copy link
Contributor

vc-ci commented May 20, 2020

SonarQube analysis reported 7 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR OrdersSynchronizationJob.cs#L61: Either remove or fill this block of code. rule
  2. MAJOR AvaTaxController.cs#L63: 'System.Exception' should not be thrown by user code. rule
  3. MAJOR AvaTaxController.cs#L73: 'System.Exception' should not be thrown by user code. rule
  4. MAJOR AvaTaxController.cs#L87: 'System.Exception' should not be thrown by user code. rule
  5. MAJOR AvaTaxController.cs#L93: 'System.Exception' should not be thrown by user code. rule
  6. MAJOR AvaTaxController.cs#L100: 'System.Exception' should not be thrown by user code. rule
  7. MINOR Module.cs#L37: Remove the field '_appBuilder' and declare it as a local variable in the relevant methods. rule

akak1977
akak1977 previously approved these changes May 21, 2020
@lnetrebskii lnetrebskii changed the base branch from dev-3.0.0 to dev May 26, 2020 06:39
@lnetrebskii lnetrebskii dismissed akak1977’s stale review May 26, 2020 06:39

The base branch was changed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Egidijus Mazeika seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants