fix(VCST-4069): back in stock search - jumping UI #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kalachikov
requested review from
Andrew-Orlov,
Copilot,
goldenmaya,
muller39 and
yuskithedeveloper
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a UI jumping issue in the back-in-stock subscriptions search by correcting the conditional rendering logic. The change prevents both the loading skeleton and the subscriptions list from rendering simultaneously, which was causing the UI to jump.
Key Change:
- Modified the subscriptions list template condition from
v-iftov-else-ifto ensure proper mutual exclusion with the loading state
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
goldenmaya
approved these changes
Oct 23, 2025
|
ivan-kalachikov
deleted the
fix/VCST-4069-back-in-stock-search-jumping-search-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4069
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.34.0-pr-2016-0663-06631147.zip