feat(VCST-4084): saved for later list page #2008
Conversation
yuskithedeveloper
requested review from
Andrew-Orlov,
goldenmaya and
ivan-kalachikov
and removed request for
a team
Bug: Route Constants ViolationAccording to the PR discussion, line 107 should use "ROUTES.SAVED_FOR_LATER.NAME" instead of the hardcoded string "SavedForLater". The reviewer @ivan-kalachikov specifically pointed this out. This violates the project's convention of using route constants instead of hardcoded strings. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
client-app/shared/wishlists/components/wishlist-products-skeleton.vue
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
| } | ||
| &__item { | ||
| &--desktop &__item { |
There was a problem hiding this comment.
we usually use this way of writing selectors in similar cases:
.wishlist-products-skeleton {
$desktop: "";
&--mobile {
@apply grid grid-cols-2 gap-x-4 gap-y-6;
}
&--desktop {
@apply flex flex-col rounded border bg-additional-50 shadow-sm;
$desktop: &;
}
&__item {
#{$desktop} & {
@apply even:bg-neutral-50;
}
}
}There was a problem hiding this comment.
could seem kind of mind breaking but will be resolved to .wishlist-products-skeleton--desktop .wishlist-products-skeleton__item
| import { useShortCart } from "@/shared/cart"; | ||
| import { ProductSkeletonGrid } from "@/shared/catalog"; | ||
| import { useWishlists, WishlistLineItems, WishlistProductItemSkeleton } from "@/shared/wishlists"; | ||
| import { WishlistProductsSkeleton } from "@/shared/wishlists"; |
There was a problem hiding this comment.
3 participants
Description
"Saved for later" list page under the account section (only available for authorized users):
"See all" button in "Saved for later" cart block:
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4084
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.34.0-pr-2008-ec9d-ec9da633.zip