feat(VCST-3991): no results search page #2006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kalachikov
requested review from
Andrew-Orlov,
goldenmaya and
yuskithedeveloper
and removed request for
a team
goldenmaya
previously approved these changes
Oct 17, 2025
goldenmaya
previously approved these changes
Oct 27, 2025
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a no-results search page feature by adding localization strings for empty search results and enhancing the search and category components to handle empty search states with improved user experience.
Key changes:
- Added
header_emptylocalization key across all language files for displaying empty search results messages - Modified search navigation to use
router.replacewhen already on search page to prevent history stack buildup - Implemented empty search state detection and conditional UI rendering to hide filters and controls when no results are found
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| locales/*.json | Added header_empty translation key for empty search results message in 13 language files |
| client-app/shared/layout/components/search-bar/search-bar.vue | Updated navigation logic to replace route when already on search page instead of pushing |
| client-app/shared/catalog/composables/useProducts.ts | Added hasSelectedFilters function and computed property to check for active filters |
| client-app/shared/catalog/components/category.vue | Implemented empty search state detection and conditional rendering of UI elements, added navigation logic for reset functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-3991
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.34.0-pr-2006-d0ec-d0eca08c.zip