Skip to content

Conversation

@yuskithedeveloper
Copy link
Contributor

@yuskithedeveloper yuskithedeveloper commented Sep 19, 2025

Description

Removed saved for later mutations batching and implemented optimistic responses support so the client doesn't wait the server to respond to rerender

References

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-3928

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.34.0-pr-1956-9ad9-9ad902b8.zip

@yuskithedeveloper
Copy link
Contributor Author

Closed until an optimistic response support for batched requests would be implemented

@yuskithedeveloper yuskithedeveloper marked this pull request as ready for review October 23, 2025 16:14
@yuskithedeveloper yuskithedeveloper requested a review from a team as a code owner October 23, 2025 16:14
@yuskithedeveloper yuskithedeveloper requested review from Andrew-Orlov, goldenmaya, ivan-kalachikov and muller39 and removed request for a team October 23, 2025 16:14
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Optimistic Move Bug Causes UI Discrepancy

The moveFromSavedForLater optimistic response only removes items from the saved-for-later list but doesn't add them to the cart. This causes items to temporarily disappear from the UI until the server response arrives.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Optimistic UI Fails to Update Destination Lists

The optimistic responses for moveToSavedForLater and moveFromSavedForLater only simulate the removal of items from their source list. They don't also optimistically add these items to their destination list (saved for later or cart, respectively). This results in items temporarily disappearing from the UI until the server response arrives.

Additional Locations (1)

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Undefined Variable Causes Length Access Error

The movedItemIds variable might be undefined if vars.command?.lineItemIds is missing. Accessing .length on an undefined value in this case would lead to a TypeError.

Additional Locations (1)

Fix in Cursor Fix in Web

cursor[bot]

This comment was marked as outdated.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants