Added support for PHP8 #34
Conversation
There was a problem hiding this comment.
Hello @JeroenVanOort,
Thanks for the contribution!
I like the change to deal with spans rather than arrays. My only concern is support of the upcoming Zipkin release that is currently under development. I suggest we avoid that until v3.0 is officially released.
Other than that, it is good to go. @Mulkave anything to add?
Thanks.
| @@ -27,7 +27,7 @@ | |||
| "illuminate/queue": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "illuminate/routing": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "illuminate/support": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "openzipkin/zipkin": "~2.0.2", | |||
| "openzipkin/zipkin": "~2.0.2|3.0.x-dev", | |||
There was a problem hiding this comment.
I don't think we should support a dev release of Zipkin at this stage, once it is released we can do so.
There was a problem hiding this comment.
I would love to avoid it too, I just hope they'll release v3 soon.
There was a problem hiding this comment.
Agreed, better keep support for stable releases only.
| */ | ||
| protected function shiftSpan(array &$spans): array | ||
| protected function shiftSpan(array &$spans): Span |
| @@ -27,7 +27,7 @@ | |||
| "illuminate/queue": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "illuminate/routing": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "illuminate/support": "~5.5.0|~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0|^8.0", | |||
| "openzipkin/zipkin": "~2.0.2", | |||
| "openzipkin/zipkin": "~2.0.2|3.0.x-dev", | |||
There was a problem hiding this comment.
Agreed, better keep support for stable releases only.
| @@ -0,0 +1,29 @@ | |||
| FROM php:8.0-cli-alpine | |||
There was a problem hiding this comment.
interesting stuff! Thanks for adding this @JeroenVanOort
Do you use it with your editor?
|
@JeroenVanOort i ran Are you sure that tests are passing for you? UPDATE it works after a |
|
I think it is good to keep the 3.0.x-dev version on the PR and keep it on
hold until we release the 3.0 (which will happen very soon).
José Carlos Chávez
tor. 23. sep. 2021 kl. 15:14 skrev Abed Halawi ***@***.***>:
… @JeroenVanOort <https://github.com/JeroenVanOort> i ran
./vendor/bin/phpunit within the worspace container and got the following:
Warning: Private methods cannot be final as they are never overridden by other classes in /var/www/html/vendor/phpunit/phpunit/src/Util/Configuration.php on line 176
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
EEE
Fatal error: Declaration of Vinelab\Tracing\Drivers\Zipkin\Propagation\IlluminateHttp::get($carrier, string $key): ?string must be compatible with Zipkin\Propagation\Getter::get($carrier, $key) in /var/www/html/src/Drivers/Zipkin/Propagation/IlluminateHttp.php on line 20
Are you sure that tests are passing for you?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYASDP3UZOOJ2X4TVNTLUDMR3BANCNFSM5ETHA5SA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I would like to use this package in a project using PHP 8, so I added compatibility for it.