fix(legend): Fix error for color.threshold option

Prevent setting legend color when chart has no legend

Fix naver#1604
Close naver#1611

AUTHORS.txt

@@ -41,3 +41,4 @@ Wonju Jeon <wonju.jeon@navercorp.com>
 ECrownofFire <ECrownofFire@gmail.com>
 Artem Savienkov <as@attractgroup.com>
 Hamid Sarfraz <praisedpk@gmail.com>
+Alan Hamlett <alan.hamlett@gmail.com>

src/ChartInternal/internals/legend.ts

@@ -199,8 +199,12 @@ export default {
 	 * @private
 	 */
 	updateLegendItemColor(id: string, color: string): void {
-		this.$el.legend.select(`.${CLASS.legendItem}-${id} line`)
-			.style("stroke", color);
+		const {legend} = this.$el;
+
+		if (legend) {
+			legend.select(`.${CLASS.legendItem}-${id} line`)
+				.style("stroke", color);
+		}
 	},
 
 	/**

test/internals/legend-spec.ts

@@ -4,6 +4,7 @@
  */
 /* eslint-disable */
 /* global describe, beforeEach, it, expect */
+import sinon from "sinon";
 import {expect} from "chai";
 import {select as d3Select} from "d3-selection";
 import util from "../assets/util";
@@ -475,8 +476,8 @@ describe("LEGEND", () => {
 		});
 	});
 
-	describe('legend item tile coloring with color_treshold', () => {
-		before(function () {
+	describe("legend item tile coloring with color_treshold", () => {
+		before(() => {
 			args = {
 				data: {
 					columns: [
@@ -512,6 +513,32 @@ describe("LEGEND", () => {
 			expect(tileColor[2]).to.be.equal('rgb(249, 118, 0)');
 			expect(tileColor[3]).to.be.equal('rgb(255, 0, 0)');
 		});
+
+		it("color.threshold should be generated without error when legend.show=false", done => {
+			const spy = sinon.spy();
+
+			util.generate({
+				data: {
+					columns: [["col-0", 2.05]], 
+					type: "gauge"
+				},
+				legend: {
+					show: false
+				},
+				color: {
+					pattern: ["#29BB9D", "#29BB9D", "#E7C248", "#FF9A0C", "#F56075"],
+					threshold: {
+						values: [20, 40, 60, 80, 100]
+					}
+				},
+				onrendered: spy
+			});
+
+			setTimeout(() => {
+				expect(spy.called).to.be.true;
+				done();
+			}, 500);
+		});
 	});
 
 	describe("legend item tile coloring without color_treshold", () => {