Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed UI icons for small device #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IshuSinghSE
Copy link

This PR Closes: #49 issue

  • Added menu for easily navigate to the pages

Please let me know for any changes required.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @IshuSinghSE for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Vinay-Khanagavi
Copy link
Owner

@IshuSinghSE Can you share the screenshot in discussion #16

@B1N4RY-P4R45173 B1N4RY-P4R45173 added enhancement New feature or request gssoc-ext GSSoC'24 Extended Version level2 25 Points 🥈 hacktoberfest-accepted Hacktoberfest 2024 priority:high Needs to be fixed immediately labels Oct 19, 2024
@B1N4RY-P4R45173
Copy link
Collaborator

@IshuSinghSE thanks for this pr. It looks great. But I think a few things could be improved.

firstly, Clicking second time on the toggle icon can set display to set the display of icon container to none, so that users doesn't have to click somewhere on the screen

Secondly, for devices with large display we don't need the display toggle

Lastly, for smaller display make sure that the levels and their description is displayed in correct order

@B1N4RY-P4R45173
Copy link
Collaborator

@Vinay-Khanagavi Here you go

{A59EFC87-9A61-4BF8-98A1-52C6B09743E9}

{C8C14E02-5DBA-4F37-A105-5216720DAE8A}

{68D08A34-8999-4A28-96DF-244CCC31CB8E}

{C4B6D97E-44BE-468C-B7BD-854F2A62B650}

@B1N4RY-P4R45173
Copy link
Collaborator

Also @IshuSinghSE

Align the contents to center so that the icons wont cover the contents

@IshuSinghSE
Copy link
Author

IshuSinghSE commented Oct 19, 2024

Also @IshuSinghSE

Align the contents to center so that the icons wont cover the contents

I will surely do the required adjustments!
Thanks for the feedback,

@B1N4RY-P4R45173 B1N4RY-P4R45173 added the Active Issues that are currently being worked upon label Oct 20, 2024
@Vinay-Khanagavi
Copy link
Owner

@IshuSinghSE Make sure project has no conflicts

@Vinay-Khanagavi Vinay-Khanagavi added the Changes required Pull request is not good enough label Oct 21, 2024
@Vinay-Khanagavi
Copy link
Owner

Please resolve conflicts

@B1N4RY-P4R45173
Copy link
Collaborator

are you still working on this @IshuSinghSE ?

@B1N4RY-P4R45173 B1N4RY-P4R45173 removed the Active Issues that are currently being worked upon label Oct 25, 2024
@IshuSinghSE
Copy link
Author

IshuSinghSE commented Oct 26, 2024

are you still working on this @IshuSinghSE ?

I was stuck, because I am unable to see Resolve conflicts here, but there are conflicts

Now I have resolved all conflicts!

@IshuSinghSE
Copy link
Author

Now I have fixed the elemetns of homepage.
127 0 0 1_5500_index html

@B1N4RY-P4R45173
Copy link
Collaborator

@IshuSinghSE I will check it tmrw. And yeah most of the times to resolve conflicts u have to rebase it. I hope u figured it by now, sry for the late response.

@IshuSinghSE
Copy link
Author

IshuSinghSE commented Oct 27, 2024

@IshuSinghSE I will check it tmrw. And yeah most of the times to resolve conflicts u have to rebase it. I hope u figured it by now, sry for the late response.

No Problem 😁,

  • I have resolved all the conflicts
  • I have made the necessary changes for large and small devices

please review and merge the PR!

@B1N4RY-P4R45173 B1N4RY-P4R45173 added level3 45 Points 🥉 and removed level2 25 Points 🥈 labels Oct 27, 2024
@B1N4RY-P4R45173
Copy link
Collaborator

@IshuSinghSE

That's some nice improvement but I think the UI could be more better.
{1B19C8A7-A2F3-483F-A0D1-E708417443D5}

starting with above screenshot, the heading (Level1 and play button) should be above the content (abt phishing attacks)

{5BDFA3F4-19F2-49B2-8222-269AAF78878E}

Here you can again set the headings and play button to the center for level 2 and 3.

Follow the order of

  • heading (level number and play button)
  • then the content (what is about)
  • and then the video

follow the same order for same order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes required Pull request is not good enough enhancement New feature or request gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 level3 45 Points 🥉 priority:high Needs to be fixed immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design a responsive UI
3 participants