-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed UI icons for small device #89
base: main
Are you sure you want to change the base?
fixed UI icons for small device #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @IshuSinghSE for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
@IshuSinghSE Can you share the screenshot in discussion #16 |
@IshuSinghSE thanks for this pr. It looks great. But I think a few things could be improved. firstly, Clicking second time on the toggle icon can set display to set the display of icon container to none, so that users doesn't have to click somewhere on the screen Secondly, for devices with large display we don't need the display toggle Lastly, for smaller display make sure that the levels and their description is displayed in correct order |
@Vinay-Khanagavi Here you go |
Also @IshuSinghSE Align the contents to center so that the icons wont cover the contents |
I will surely do the required adjustments! |
@IshuSinghSE Make sure project has no conflicts |
Please resolve conflicts |
are you still working on this @IshuSinghSE ? |
I was stuck, because I am unable to see Resolve conflicts here, but there are conflicts Now I have resolved all conflicts! |
0ba6d38
to
2a2d8c3
Compare
@IshuSinghSE I will check it tmrw. And yeah most of the times to resolve conflicts u have to rebase it. I hope u figured it by now, sry for the late response. |
No Problem 😁,
please review and merge the PR! |
This PR Closes: #49 issue
Please let me know for any changes required.