Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#129 resolved , aligned content of home page #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anshxika
Copy link

here is the final result for home page:

Screen.Recording.2024-10-24.033430.mp4

( the made changes don't affect the website in any negative aspect , the changes commited just made the code easier, shorter along with achieving the desired result)

@Vinay-Khanagavi if its approved please add the hacktoberfest and gssoc labels and assign that issue to me (you had asked to pull pr first for review)
thankyou

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @anshxika for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Vinay-Khanagavi
Copy link
Owner

What about responsive in mobile !?

@anshxika
Copy link
Author

anshxika commented Oct 24, 2024

@Vinay-Khanagavi this issue was for the desktop view, if you want i can pull a second PR for that and kindly merge this PR please along with the tags (current @media code is working okay, if wanted will pull a second PR for better alignment on mobile view), if you have have any other desired changes in this scenario let me know
thanks

@Vinay-Khanagavi
Copy link
Owner

Actually we wanted the homepage in this format : https://vinay-khanagavi.github.io/Cyberbear.github.io/
which is already in correct format

@anshxika
Copy link
Author

so you want the bear gif bellow the text , like its for level 1 right now?

@Vinay-Khanagavi
Copy link
Owner

Vinay-Khanagavi commented Oct 24, 2024

Everything is fine in the current code just because of some contributor mistake we just did rollback, just add the 4th gif which is not visible I'll accept your merge. Just pull the code and remove the changes you made and just update the 4th gif looks according to the 2nd gif

@anshxika
Copy link
Author

sorry but all the gifs are visible already and 4th gif and 2nd gif are also already same , it's the 3rd gif that's elongated, 4th gif is already according to the format in https://vinay-khanagavi.github.io/Cyberbear.github.io/

@Vinay-Khanagavi
Copy link
Owner

image

@Vinay-Khanagavi Vinay-Khanagavi added the Changes required Pull request is not good enough label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes required Pull request is not good enough
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants