Skip to content

Fix None access exception#344

Open
tyru wants to merge 2 commits intoVimjas:masterfrom
tyru:fix-none-empty-entry
Open

Fix None access exception#344
tyru wants to merge 2 commits intoVimjas:masterfrom
tyru:fix-none-empty-entry

Conversation

@tyru
Copy link
Copy Markdown
Collaborator

@tyru tyru commented Jan 11, 2020

When empty entry in config like this:

policies:

vint always raises an exception.

AttributeError: 'NoneType' object has no attribute 'keys'

When empty entry in config like this:

```
policies:
```

vint always raises an exception.

```
AttributeError: 'NoneType' object has no attribute 'keys'
```
@tyru
Copy link
Copy Markdown
Collaborator Author

tyru commented Jan 11, 2020

CI failed but I don't know how to fix this...

@blueyed blueyed force-pushed the fix-none-empty-entry branch from 716515e to 4fd6ada Compare January 11, 2020 19:32
@blueyed
Copy link
Copy Markdown
Member

blueyed commented Jan 11, 2020

Thanks, remove support for Python 3.4, and rebased it.
Might be good to have a test, and/or better error message in this case.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 11, 2020

Coverage Status

Coverage decreased (-0.1%) to 96.28% when pulling 7758955 on tyru:fix-none-empty-entry into 427de13 on Kuniwak:master.

@Vimjas Vimjas deleted a comment from codecov-io Jan 11, 2020
@blueyed blueyed force-pushed the fix-none-empty-entry branch from 4fd6ada to f1ee41f Compare January 11, 2020 19:44
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2020

Codecov Report

Merging #344 into master will decrease coverage by 0.14%.
The diff coverage is 68.18%.

@@           Coverage Diff            @@
##           master   #344      +/-   ##
========================================
- Coverage   94.14%    94%   -0.15%     
========================================
  Files         133    133              
  Lines        4152   4167      +15     
  Branches      417    418       +1     
========================================
+ Hits         3909   3917       +8     
- Misses        150    156       +6     
- Partials       93     94       +1

@tyru tyru force-pushed the fix-none-empty-entry branch from f1ee41f to 4ef550f Compare January 12, 2020 09:27
@tyru tyru force-pushed the fix-none-empty-entry branch from 4ef550f to 7758955 Compare January 12, 2020 09:28
@tyru
Copy link
Copy Markdown
Collaborator Author

tyru commented Jan 12, 2020

@blueyed sorry, I have no enough time to do it.
if you feel 7758955 is good, please merge it,
or wait until for a while... or you can implement it :)

@blueyed blueyed added the bug label Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants