Enhance Simba with the power of the rainbow🌈 #551
Open
Torwent wants to merge 8 commits intoVillavu:simba2000from
Open
Enhance Simba with the power of the rainbow🌈 #551Torwent wants to merge 8 commits intoVillavu:simba2000from
Torwent wants to merge 8 commits intoVillavu:simba2000from
Conversation
Contributor
Author
var
STR: String = 'Hello world!';
begin
WriteLn #0#0#4 + '00A0FF' + STR;
end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives full BGR output color support to Simba output (and editor I think).
I'm not sure if you would like this in Simba or not but I think it's kinda nice to have things more flexible and also extensible as I made it somewhat easy to add a few more flags in the future if we want. Speed wise, should be roughly the same as before except special strings have one extra byte.
This is also likely my biggest Simba change ever so I would appreciate it if do a good review of my changes in case I missed anything and of course, you are free to change and improve anything you don't like about it.
Here is a video preview of what this does:
https://github.com/user-attachments/assets/492e9153-5d05-480f-9d5e-2372bc909a13
One thing I was also considering was controling the "Alpha" which you have hard coded but I kinda like this tinted look.
Anyway if this is merged, I would also like to also try and give per character color inside of each line someday.
But that would be something for another day and it would be quite a different proposal as that requires iterating over the string.
My idea would be to add a TEXT_COLOR flag to know we have character colors enconded in the string and if we have that flag we iterate the string looking for #0#0'BBGGRR' and color the next characters.
But yeah, something for another day!