Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Slots as potential successor to Content Areas #348

Merged
merged 16 commits into from
Jun 30, 2020
Merged

Implement Slots as potential successor to Content Areas #348

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ebf506
Implement Slots as potential successor to Content Areas
joelhawksley May 13, 2020
98249e0
apply suggestions from code review
joelhawksley Jun 15, 2020
87cc569
add link to PR in README
joelhawksley Jun 15, 2020
5d874e7
add note about subclassing for slots
joelhawksley Jun 15, 2020
2b584dd
fix typo in README
joelhawksley Jun 15, 2020
79e754d
remove class_eval risk, update comments
joelhawksley Jun 15, 2020
87a27dd
Update lib/view_component/base.rb
joelhawksley Jun 16, 2020
d356522
Merge branch 'master' into slots
joelhawksley Jun 16, 2020
c1b73da
move slot behavior to module
joelhawksley Jun 29, 2020
c57e79d
use concern instead of module
joelhawksley Jun 29, 2020
cc4ddc8
do not generate classes for anonymous slots
joelhawksley Jun 29, 2020
d04cd13
raise error if slot does not inherit from ViewComponent::Slot
joelhawksley Jun 29, 2020
1f5066d
Merge branch 'master' into slots
joelhawksley Jun 29, 2020
841ff62
Update README.md
joelhawksley Jun 29, 2020
532704e
rubocop
joelhawksley Jun 29, 2020
6000376
Update lib/view_component/slotable.rb
joelhawksley Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into slots
  • Loading branch information
@joelhawksley
joelhawksley committed Jun 29, 2020
commit 1f5066dc607907a870959877eef18ce988eda9dd
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

*Jens Ljungblad, Brian Bugh, Jon Palmer, Joel Hawksley*

# 2.11.1

* Fix kwarg warnings in Ruby 2.7.

*Joel Hawksley*

# 2.11.0

* Ensure Rails configuration is available within components.
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.