remove deprecated autoscaling/v2beta1 HPA objects #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haleygo
force-pushed
the
remove-deprecated-beta-hpa
branch
from
9552647
to
b454f3f
Compare
f41gh7
reviewed
Feb 7, 2024
| @@ -79,12 +68,9 @@ func IsFSGroupChangePolicySupported() bool { | |||
| return false | |||
| } | |||
|
|
|||
| // NewHPAEmptyObject returns HorizontalPodAutoscaler object for given kubernetes version | |||
| // NewHPAEmptyObject returns HorizontalPodAutoscaler object | |||
| func NewHPAEmptyObject(opts ...func(obj client.Object)) client.Object { | |||
There was a problem hiding this comment.
I think, we should remove `client.Object from this function and return exact type. It can be done at follow-up commit.
|
Thanks! |
Unfortunately, it's not possible to support EoL versions of kubernetes properly. I think, soon we're going to redesign resource reconciliation a bit. It must fix possible errors with incompatible resources. If resource don't use deprecated API directly, it shouldn't trigger any errors by calling deprecated kubernetes APIs. Related issue #758 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #864,
since operator supports k8s version from 1.25 now, there is no need to have autoscaling/v2beta1.