-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spec params description #1245
Conversation
6b26271
to
600b8a3
Compare
2fcb1ed
to
3bf3992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'm not sure about using HTML tags, they make README better but the values.yaml is a bit messy.
I would also like to keep markdown tables instead of html ones, but multiline content breaks markdown tables and markdown is not rendered inside html. I can add to hugo-docs a PR, which adds function, which allow markdown to html conversion |
36bf922
to
30367d7
Compare
removed HTML tags from values and and rendered documentation by helm-docs binary from this PR |
da56508
to
03cfe3e
Compare
03cfe3e
to
6b4b57c
Compare
4b2c455
to
5f42f62
Compare
@Haleygo |
5f42f62
to
7cc1bf1
Compare
A minor question: is there a way to support value's comment without adding the prefix |
as far as i know and also you can see it in code helm-docs expects all comments to start with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related issues #1244 #255