app/vmui: feature: add selectable bars count for hits/stats charts #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictoriaMetrics#956) - add bars count dropdown with predefined steps (12..1240, default 96) - persist bars count across URL/search params and reuse for Query/Overview flows - pass bars count through fetch, time bucketing, and uPlot rendering for consistent bar sizing - allow SERVER_URL override via localStorage for remote backend testing Fixes VictoriaMetrics#956
withlin
changed the title
Contributor
|
@withlin , thank you for the pull request! @Loori-R , @arturminchukov , could you review this PR? |
valyala
added
the
web-ui
Loori-R
requested changes
Dec 31, 2025
Contributor
There was a problem hiding this comment.
For sync with PR #988 (bar rendering fix), this file should not be changed. paths no longer depends on bars count.
Contributor
There was a problem hiding this comment.
For sync with PR #988: app/vmui/packages/vmui/src/utils/uplot/paths.ts will be removed, so please avoid making changes here.
| }; | ||
|
|
||
| export const getHitsTimeParams = (period: TimeParams) => { | ||
| export const getHitsTimeParams = (period: TimeParams, barsCount = LOGS_DEFAULT_BAR_COUNT) => { |
Contributor
There was a problem hiding this comment.
To avoid conflicts with PR #988, could you align this with the implementation from
VictoriaLogs/app/vmui/packages/vmui/src/utils/logs.ts
Lines 12 to 22 in 08d08b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #956
default.mov