Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react 17 update #54

Closed
wants to merge 1 commit into from
Closed

Conversation

RamonDonnell
Copy link

@RamonDonnell RamonDonnell commented Jul 3, 2021

Dependency and jest setup update for react 17.
Uses unofficial @wojtekmaj/enzyme-adapter-react-17

#53

  • Fork the repository
  • Develop your code changes
  • Ensure eslint is happy: npm run lint
  • Ensure the tests pass: npm test
  • Commit your changes
  • Push to your fork
  • Submit a pull request

@VictorCazanave
Copy link
Owner

Thanks for your contribution @RamonDonnell ! 😃

Does it solve the issue #53?
If yes, since the components aren't modified, can't we just update the peerDependencies to support both React 16 and 17 (^16.0.0 || ^17.0.0)? 🤔

@sdnalloh
Copy link

Please resolve and merge this pull request.
I'd like to use react-svg-map with react-17, and I'm sure many other people would too.

@piotrgregor
Copy link

piotrgregor commented Mar 5, 2022

Yes, other people too ;p
Can this be merged please.

@VictorCazanave
Copy link
Owner

As mentioned in #53, I didn't see any issue using these components with React 17.
So @sdnalloh @piotrgregor what do you need exactly? Only updating the peer dependencies to also support React 17?
If there is an issue with React 17, please provide a repository with a minimal example to reproduce it.

@VictorCazanave
Copy link
Owner

Thanks again for your contribution @RamonDonnell, but stopping React 16 support is a major change that will be done in the v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants