Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Map! #24

Merged
merged 8 commits into from
Apr 13, 2019
Merged

Heat Map! #24

merged 8 commits into from
Apr 13, 2019

Conversation

amonraRivers
Copy link
Contributor

Added the ability to add css classnames to individual locations based on user and context needs.

@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          76     77    +1     
  Branches       17     18    +1     
=====================================
+ Hits           76     77    +1
Impacted Files Coverage Δ
src/svg-map.jsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb2262...1604d4c. Read the comment docs.

@amonraRivers amonraRivers reopened this Apr 5, 2019
@VictorCazanave
Copy link
Owner

This is an interesting feature, thanks @ramosquito5 😃
I'll review your merge request this weekend

Copy link
Owner

@VictorCazanave VictorCazanave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too busy last weekend, sorry 🙏
I didn't have time to look at it seriously but instead of adding the handleLocationClasses prop, would it be possible to modify locationClassName to accept a string or a function (like locationTabIndex)?

.vscode/settings.json Outdated Show resolved Hide resolved
@VictorCazanave VictorCazanave added the enhancement New feature or request label Apr 10, 2019
@amonraRivers
Copy link
Contributor Author

Ok, will do, thanks!

@VictorCazanave
Copy link
Owner

Thanks for your quick update! Everything looks good 😃
I will just make some quick tests (hopefully tonight), then merge it and publish a new version.

@VictorCazanave VictorCazanave self-requested a review April 13, 2019 07:40
@VictorCazanave VictorCazanave merged commit 5e07fb9 into VictorCazanave:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants