Open
Conversation
Co-authored-by: dadudekc <dadudekc@gmail.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
flowr-mockup/app.js
Outdated
| if (!autoFinishTs) return state; | ||
| if (now < autoFinishTs) return state; | ||
|
|
||
| const finished = { ...state, finishTs: now }; |
There was a problem hiding this comment.
Auto-finish records current time instead of scheduled time
When finishIfDue auto-finishes a session, it sets finishTs to now (the current time when the check runs) rather than autoFinishTs (the scheduled finish time). If a user closes and reopens the page after the scheduled finish time, the recorded finish time and elapsed duration will be incorrect—showing the time of page reload rather than when the session was actually supposed to end. For example, a session scheduled to end at 4:00 PM would show a finish time of 5:00 PM if the page is reopened at 5:00 PM.
Co-authored-by: dadudekc <dadudekc@gmail.com>
Co-authored-by: dadudekc <dadudekc@gmail.com>
This commit introduces a new state version (v2) with a more structured approach to storing session data, settings, and UI states. It also adds several new features including focus mode, wake lock, improved history management, and a confirmation modal for session endings. The code has been refactored to better handle these changes and improve overall maintainability. Co-authored-by: dadudekc <dadudekc@gmail.com>
Co-authored-by: dadudekc <dadudekc@gmail.com>
Co-authored-by: dadudekc <dadudekc@gmail.com>
Co-authored-by: dadudekc <dadudekc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Flowr UI mockup with an auto-finishing timer.
This PR implements a timer that automatically finishes a "smoking" session based on a rule ("next hour" or "fixed duration"), addressing the user's desire for a timer that "just knows" when it's done without manual intervention. It also includes intro/outro messages and optional keyword commands.
Note
Introduces a standalone web mockup for Flowr with a client-side session timer and auto-finish logic.
flowr-mockup/withindex.html,styles.css, andapp.jsidle→running→finished) with localStorage persistencenextHour(top of next hour) orduration(N minutes), including manual finish/resetsmoke/done/reset/help)Written by Cursor Bugbot for commit c7059a8. Configure here.