added some better questions :) #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added some new question to questions_acronyms.py, questions_back_end.py, questions_front_end.py, questions_pop_culture.py, questions_version_control.py
VickiLanger
reviewed
Mar 17, 2020
questions_pop_culture.py
Outdated
| '🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty | ||
| 'Who was the first Disney Princess? @DisneyStudios' #Disney | ||
| 'Who created Mickey Mouse? @DisneyStudios #Disney' #Disney #MickeyMouse | ||
| 'Why is Hacktoberfest done only once in a year? @Hacktoberfest #Hacktoberfest2020' |
Owner
There was a problem hiding this comment.
This is a great question. Remember to follow the example in issue #5
'question goes here', # short answer goes here, add a link if it's not a short answerAnd the below to keep in line with Python syntax
- Each question should be in its own line
- Surrounded by single quotes (
') - Keep the trailing comma
VickiLanger
reviewed
Mar 17, 2020
questions_pop_culture.py
Outdated
| 'In "Silicon Valley" Season 3 Episode 1, what language is being used?\n@SiliconHBO', # https://www.reddit.com/r/SiliconValleyHBO/comments/4gbra7/i_got_the_silicon_valley_s03e01_code_to_compile/) | ||
| 'What day is celebrated as Programmer\'s day? Why?\n#ProgrammersDay', # | ||
| '🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty | ||
| 'Who was the first Disney Princess? @DisneyStudios' #Disney |
Owner
There was a problem hiding this comment.
This is a fun question, but is it code-related?
Code Questions bot is meant to help developers learn code things together.
VickiLanger
reviewed
Mar 17, 2020
questions_pop_culture.py
Outdated
| 'What day is celebrated as Programmer\'s day? Why?\n#ProgrammersDay', # | ||
| '🐠In Mr. Robot, what is the name of Elliot\'s betta fish? @whoismrrobot #MrRobot', # Qwerty | ||
| 'Who was the first Disney Princess? @DisneyStudios' #Disney | ||
| 'Who created Mickey Mouse? @DisneyStudios #Disney' #Disney #MickeyMouse |
Owner
There was a problem hiding this comment.
This is a fun question, but is it code-related?
VickiLanger
requested changes
Mar 17, 2020
Owner
VickiLanger
left a comment
VickiLanger
left a comment
There was a problem hiding this comment.
Lots of great questions! Thanks for adding them. If you wouldn't mind, please address the comments I left.
Also, I'd like to add you to the Contributors list. Do. you have a Twitter handle you'd like me to include?
Author
|
Thank you
…On Wed, Mar 18, 2020, 2:04 AM Vicki ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Lots of great questions! Thanks for adding them. If you wouldn't mind,
please address the comments I left.
Also, I'd like to add you to the Contributors list. Do. you have a Twitter
handle you'd like me to include?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO3IDYCYCL5FOOV7OP4D2W3RH7NFJANCNFSM4LNPJMZA>
.
|
questions were mickey mouse
VickiLanger
approved these changes
Apr 6, 2020
Owner
VickiLanger
left a comment
VickiLanger
left a comment
There was a problem hiding this comment.
All adjustments made. Ready to merga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some new question to questions_acronyms.py, questions_back_end.py, questions_front_end.py, questions_pop_culture.py, questions_version_control.py