Skip to content

build: fix shader compile error on Windows #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViTeXFTW merged 1 commit into from
Jan 29, 2026
Merged

build: fix shader compile error on Windows #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,18 @@ if(NOT BUILD_TESTING)

# Generate embedded shaders header
set(EMBEDDED_HEADER "${CMAKE_BINARY_DIR}/generated/embedded_shaders.hpp")
set(SHADER_LIST_FILE "${CMAKE_BINARY_DIR}/generated/shader_list.txt")

# Escape semicolons in the list for passing to cmake -P
string(REPLACE ";" "\\;" SPIRV_OUTPUTS_ESCAPED "${SPIRV_OUTPUTS}")
# Write shader list to a file (more reliable than command-line args)
file(WRITE "${SHADER_LIST_FILE}" "")
foreach(SHADER_FILE ${SPIRV_OUTPUTS})
file(APPEND "${SHADER_LIST_FILE}" "${SHADER_FILE}\n")
endforeach()

add_custom_command(
OUTPUT "${EMBEDDED_HEADER}"
COMMAND ${CMAKE_COMMAND}
"-DSHADER_FILES=${SPIRV_OUTPUTS_ESCAPED}"
"-DSHADER_LIST_FILE=${SHADER_LIST_FILE}"
"-DOUTPUT_FILE=${EMBEDDED_HEADER}"
-P "${CMAKE_SOURCE_DIR}/cmake/EmbedShaders.cmake"
DEPENDS ${SPIRV_OUTPUTS} "${CMAKE_SOURCE_DIR}/cmake/EmbedShaders.cmake"
Expand Down
14 changes: 10 additions & 4 deletions cmake/EmbedShaders.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
# EmbedShaders.cmake - Generate C++ header with embedded SPIR-V shaders
# Usage: cmake -DSHADER_FILES="file1;file2;..." -DOUTPUT_FILE="output.hpp" -P EmbedShaders.cmake
# Usage: cmake -DSHADER_LIST_FILE="list.txt" -DOUTPUT_FILE="output.hpp" -P EmbedShaders.cmake

if(NOT SHADER_FILES)
message(FATAL_ERROR "SHADER_FILES not specified")
if(NOT SHADER_LIST_FILE)
message(FATAL_ERROR "SHADER_LIST_FILE not specified")
endif()

if(NOT OUTPUT_FILE)
message(FATAL_ERROR "OUTPUT_FILE not specified")
endif()

# Read shader files from the list file
file(STRINGS "${SHADER_LIST_FILE}" SHADER_FILES)
if(NOT SHADER_FILES)
message(FATAL_ERROR "No shader files found in ${SHADER_LIST_FILE}")
endif()

# Ensure output directory exists
get_filename_component(OUTPUT_DIR "${OUTPUT_FILE}" DIRECTORY)
file(MAKE_DIRECTORY "${OUTPUT_DIR}")
Expand Down Expand Up @@ -80,7 +86,7 @@ endforeach()

# Create a getter function that returns shader data by name
file(APPEND "${OUTPUT_FILE}" "// Get shader by name\n")
file(APPEND "${OUTPUT_FILE}" "inline std::span<const uint8_t> getShader(std::string_view name) {\n")
file(APPEND "${OUTPUT_FILE}" "inline std::span<const uint8_t> getShader([[maybe_unused]] std::string_view name) {\n")

set(FIRST_SHADER TRUE)
foreach(SHADER_NAME ${SHADER_NAMES})
Expand Down