fix: initialize bone matrix buffer with rest pose transforms #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
This PR fixes a critical initialization issue where the bone matrix buffer for GPU skinning was not populated for models without animations. The fix ensures models with skeletons but no active animations still render correctly by initializing the buffer with rest pose transforms after skeleton computation.
boneMatrixBuffer_with rest pose skinning matrices afterskeletonPose_.computeRestPose()Confidence Score: 5/5
skeletonPose_.isValid()), and follows the established code style. The fix addresses a real initialization gap where GPU-skinned models without animations would have uninitialized bone matrices.Important Files Changed
Context used:
dashboard- CLAUDE.md (source)dashboard- CLAUDE.md (source)