-
Notifications
You must be signed in to change notification settings - Fork 24
Added option to specify list of module names instead of single module name #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lciernik
reviewed
Aug 4, 2025
Collaborator
lciernik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on where things could be done slightly differently.
Some questions remain:
- Where is the backward compatibility logic when module_name is given? It appears to me that
_extract_batchwill, in any case, return a dictionary of module names and features. - We can apply alignment of representations. See
alignmethod intorch.py. Does this still work with multiple module_names? - What happens if the dataset is huge?
lciernik
reviewed
Aug 4, 2025
Collaborator
lciernik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have some comments.
lciernik
reviewed
Aug 6, 2025
LukasMut
approved these changes
Aug 6, 2025
lciernik
approved these changes
Aug 6, 2025
Collaborator
|
This fixes issue #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality to save multiple intermediate features in a single forward pass.
This is implemented through a new argument
module_names. Now eithermodule_nameormodule_namesneed to be supplied. This is done for backwards compatibility (everything should still work with justmodule_name).One change needed to be made, which is that
featuresis now a Dict frommodule_nameto correspondingfeatures_module, and the filename, which the features are saved under, now includes themodule_name. Need to double check whether this breaks anything w.r.t. backward compatibility.