Compilation: read entire source into a buffer before processing it #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reading one byte at a time via a reader, just read the whole thing into a []u8 and operate on it from there.
andrewrk
reviewed
Oct 9, 2023
src/Compilation.zig
Outdated
Comment on lines
1087
to
1089
| // Important: do not perform any possibly-failing operations in this function after this realloc. | ||
| // Otherwise errdefers in callers will possibly free the realloced slice using the original len | ||
| // instead of the new |
There was a problem hiding this comment.
Check this out, you can put this on the next line:
errdefer @compileError("errdefers in callers would possibly free the realloced slice using the original len");There was a problem hiding this comment.
oh wow, that's awesome!
Trick the compiler into thinking error.StreamTooLong can be returned from addSourceFromBuffer in 32-bit builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading one byte at a time via a reader, just read the whole thing into a []u8 and operate on it from there.
Not sure why I did it one byte at a time via a reader originally but this way is faster:
parsing sqlite3.c, master branch
parsing sqlite3.c, this branch,
Tests in ReleaseFast, master branch
Tests in ReleaseFast, this branch: