Skip to content

feat: show missing coverage lines #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2021
Merged

feat: show missing coverage lines #47

merged 6 commits into from
Sep 1, 2021

Conversation

jeroen-meijer
Copy link
Contributor

@jeroen-meijer jeroen-meijer commented Aug 20, 2021 •
edited
Loading

Description

This PR includes some new functionality that shows the lines that coverage is missing for when a build is not valid (i.e., coverage < min_coverage).

Solves #46.

Example Output

95 is less than min_coverage 100
    
Lines not covered:
  /Users/felix/Development/github.com/felangel/bloc/packages/bloc/lib/src/bloc_observer.dart: 20, 27, 36, 43, 51

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jeroen-meijer jeroen-meijer added the feature A new feature or request label Aug 20, 2021
@jeroen-meijer jeroen-meijer self-assigned this Aug 20, 2021
bselwe
bselwe reviewed Aug 20, 2021
View reviewed changes
bselwe
bselwe previously approved these changes Aug 20, 2021
View reviewed changes
Copy link

@bselwe bselwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

felangel
felangel suggested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking the time to do this! Can we add tests?

@jeroen-meijer jeroen-meijer force-pushed the feat/show-missing-coverage-lines branch from 82292f7 to aee6ba4 Compare September 1, 2021 11:55
jorgecoca
jorgecoca reviewed Sep 1, 2021
View reviewed changes
.github/workflows/test.yml Outdated
@@ -11,6 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: node --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, that was there for debugging purposes. Good catch!
Removing.

jorgecoca
jorgecoca reviewed Sep 1, 2021
View reviewed changes
@jeroen-meijer jeroen-meijer force-pushed the feat/show-missing-coverage-lines branch from 7e9a743 to 3445f43 Compare September 1, 2021 12:47
jorgecoca
jorgecoca approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@jorgecoca jorgecoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felangel
felangel approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jeroen-meijer jeroen-meijer merged commit a78ce18 into main Sep 1, 2021
@jeroen-meijer jeroen-meijer deleted the feat/show-missing-coverage-lines branch September 1, 2021 14:07
@felangel felangel mentioned this pull request Sep 17, 2021
Closed
@felangel
Copy link
Contributor

felangel commented Feb 7, 2022

closed #44

@felangel felangel linked an issue Feb 7, 2022 that may be closed by this pull request
Display the overall coverage rate in the CI #44
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kirpal Kirpal Kirpal left review comments

@jorgecoca jorgecoca jorgecoca approved these changes

@felangel felangel felangel approved these changes

@bselwe bselwe bselwe left review comments

@orestesgaolin orestesgaolin Awaiting requested review from orestesgaolin

Assignees

@jeroen-meijer jeroen-meijer

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display the overall coverage rate in the CI
5 participants
@jeroen-meijer @felangel @jorgecoca @Kirpal @bselwe