feat: update lints for Dart 3.5 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
update-lints
branch
from
cda9bbb
to
3f5595e
Compare
1 task
alestiago
reviewed
Aug 19, 2024
lishaduck
force-pushed
the
update-lints
branch
from
3f5595e
to
c05d8dd
Compare
alestiago
previously approved these changes
Aug 20, 2024
There was a problem hiding this comment.
I've gone through all the issues and read through them, the changes seem reasonable.
The only rule that has a bit of a wishy-washy discussion is prefer_void_to_null, arguments can be made for the both sides discussed in dart-lang/linter#4758. However, I think the false positives are valid considerations.
Nudging @wolfenrain so he can drop his two cents.
wolfenrain
previously approved these changes
Aug 23, 2024
lishaduck
force-pushed
the
update-lints
branch
from
c05d8dd
to
c1e2eb5
Compare
alestiago
approved these changes
Aug 23, 2024
|
Any ETA or news about this PR being merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Description
Fixes: #107.
This adds newly recommended lints and removes recently removed lints.
Lints which were only under discussion for removal or which haven't been released as recommended were skipped for now.
I can squash commits later, I wanted to keep them separate for review.
Also, I marked this as a draft. Should it be a draft? Is this mergeable on it's own, and I should make a new PR for more opinionated changes?
Type of Change