Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to move Viewer to Modules. #27

Open
mrEuler opened this issue Dec 1, 2020 · 0 comments
Open

Try to move Viewer to Modules. #27

mrEuler opened this issue Dec 1, 2020 · 0 comments
Assignees
@VBT-YTokan @DanyShevVBT @mrEuler @ToshevAlexander
Labels
enhancement New feature or request

Comments

@mrEuler
Copy link
Contributor

mrEuler commented Dec 1, 2020

Not sure how it will look like.. But let's think about it.
Viewer -> AbstractModule
|---> PerspectiveCamera is instance
|---> WebGLRenderer is instance
|---> Scene is instance

Or we can divide viewer in to several pieces:

WebGLModule -> WebGLRenderer
PerspectiveCameraModule -> PerspectiveCamera
Scene is always in ModulesProcessor as main root Object3D

Any thoughts? 🤔
@mrEuler mrEuler added the enhancement New feature or request label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VBT-YTokan VBT-YTokan

@DanyShevVBT DanyShevVBT

@mrEuler mrEuler

@ToshevAlexander ToshevAlexander

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@VBT-YTokan @DanyShevVBT @mrEuler @ToshevAlexander