Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nested changeset error handling. #5

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Support for nested changeset error handling. #5

merged 4 commits into from
Apr 16, 2019

Conversation

ademirovic
Copy link

@ademirovic ademirovic commented Apr 2, 2019 •
edited
Loading

Changes

  • Support for nested changeset error handling. When first element in errors list is a map, we have encountered nesting.
  • Support for suberrors. Previously when suberrors happend, poison would throw Poison.EncodeError because suberrors were a keyword list.
  • Tests for nested changeset. Examples of tests were written according to problems I currently encountered in my application.

space-measurer
space-measurer reviewed Apr 2, 2019
View reviewed changes
Copy link
Contributor

@space-measurer space-measurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job!

neektza
neektza reviewed Apr 5, 2019
View reviewed changes
lib/formatters/ecto/changeset.ex Outdated Show resolved Hide resolved
lib/formatters/ecto/changeset.ex Outdated Show resolved Hide resolved
test/formatters/ecto/changeset_test.exs Show resolved Hide resolved
pozhega
pozhega reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@pozhega pozhega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Few style comments and suggestions left though. :)

@pozhega pozhega merged commit a002ae9 into master Apr 16, 2019
@ademirovic ademirovic mentioned this pull request Apr 17, 2019
Open
@ademirovic ademirovic deleted the feature/nested_changesets branch April 17, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neektza neektza neektza left review comments

@pozhega pozhega pozhega left review comments

@space-measurer space-measurer space-measurer left review comments

@tpiha tpiha Awaiting requested review from tpiha

@monorkin monorkin Awaiting requested review from monorkin

@tdebus tdebus Awaiting requested review from tdebus

@zvlasic zvlasic Awaiting requested review from zvlasic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ademirovic @neektza @pozhega @space-measurer