Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): Replace urljoin by directly concatenting URL components #58

Closed
wants to merge 1 commit into from
Closed

fix(cdk): Replace urljoin by directly concatenting URL components #58

wants to merge 1 commit into from

Commits on Oct 30, 2023

  1. Replaced urllib.parse.urljoin() with a private _urljoin(). Addresses … 

    …changes made in Python 3.11 urllib.parse.urlsplit() which is implicitly called by urllib.parse.urljoin(): python/cpython#103848

CDK guarantee's a static URL is returned from the default Api stage: https://github.com/aws/aws-cdk/blob/v2.103.1/packages/@aws-cdk/aws-apigatewayv2-alpha/lib/http/stage.ts#L188-L192

So, since we're only appending some desired path to the base of the HttpApi URL, we extrapolate and format the scheme + netloc, concatenate the path, then return the result.
    @j-pepito
    j-pepito committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b882458 View commit details
    Browse the repository at this point in the history