Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gha setup go cache issue [#1319] #1320

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

tinaboyce
Copy link
Contributor

@tinaboyce tinaboyce commented Jul 21, 2024

While looking at the GitHub Action runner executing a job, I have noticed an error during the "Set up Go 1.x" stage

Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/saml2aws/saml2aws. Supported file pattern: go.sum

A quick look at the documentation and it had the actions/checkout before the actions/setup-go, while we had it afterwards, which probably explains why it cannot find go.sum.

Also (the bit that was outside the scope of the initial issue but I wanted to save multiple PRs):

I am more than happy to move the "also" bit to a new PR if that is more ideal?

Closes #1319

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.19%. Comparing base (99d6fe4) to head (36c8b29).
Report is 50 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          54       54           
  Lines        6456     6456           
=======================================
  Hits         2724     2724           
  Misses       3283     3283           
  Partials      449      449           
Flag Coverage Δ
unittests 42.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon merged commit 9990cfe into Versent:master Jul 22, 2024
8 checks passed
@mapkon
Copy link
Member

mapkon commented Jul 22, 2024

I still prefer formatting changes to be separate from material changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions "Set up Go 1.x" is giving Restore cache failed warning
3 participants