Skip to content

Conversation

@d3dc
Copy link

@d3dc d3dc commented Mar 20, 2018

This will cause the store merge to patch an existing record using ramda's mergeDeepRight

This addresses #34.

Add tests to 'success.test.ts' and 'reducersFor.test.ts' for both list and map

(I think I may have been the first to autoformat according to the .editorconfig too...)

…er merge using ramda's `mergeDeepRight`

Add tests to 'success.test.ts' and 'reducersFor.test.ts' for both list and map
@sporto
Copy link
Contributor

sporto commented Mar 22, 2018

hi @d3dc thanks for working on this. Following the discussion in #34 it seems that people have different ideas on how this should behave. Would you be willing to modify your PR so the config takes functions for the update. e.g. something like a function that takes the prev item, the new item and returns the merged item. In that way we can support anything that people have in mind. The default function would be the current way of doing things.

Also, please keep the previous whitespace formatting, changing the indentation makes it harder to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants