feat: 👷 Split CI and CD flows #31
Conversation
Also makes sure docker doesn't run on PRs
There was a problem hiding this comment.
Pull request overview
Splits the combined CI/CD GitHub Actions workflow into separate CI and CD workflows to prevent docker image publishing from running on pull requests.
Changes:
- Renamed the existing combined workflow to CI and removed docker + deploy jobs from it.
- Added a new CD workflow that runs quality checks, builds/pushes docker images, and deploys on pushes to
main.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/CI.yml | Keeps only the quality checks under CI; removes docker build/push and deploy jobs. |
| .github/workflows/CD.yml | New workflow to run quality → docker → deploy on push to main. |
Comments suppressed due to low confidence (1)
.github/workflows/CI.yml:7
- CI workflow currently runs on
pushtomainand the new CD workflow also runs onpushtomain(and includes the samequalityreusable workflow). This will cause duplicatequalityruns for every merge/push tomain, increasing CI time and noise. Consider changing CI to run only onpull_request(or onpushto non-main branches), and keepqualityin CD as the gate for docker/deploy, or alternatively trigger CD from CI viaworkflow_runso quality is not executed twice.
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ToothyDev
requested review from
Paillat-dev and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ToothyDev
force-pushed
the
feat/split-ci-cd
branch
from
e587b69 to
140ea56
Compare
2 participants
This splits the CI and CD flows into separate workflows, and also makes sure docker doesn't run on PRs, which clutters our package index