Skip to content

Feature/backup restore api based python code #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ashviniwaghmode
Copy link
Collaborator

Open source the single and group VM backup and restore API code


headers = {"Content-Type" : "application/vnd.netbackup+json;version=4.0"}

# Get the base NetBackup url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments before each function definition contribute nothing. They're essentially just the function name without the underscores. The docstrings and function names ought to be sufficient descriptions of the functions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this common.py file, have small functions so described according to that only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand that response.

rkennedy
rkennedy previously approved these changes Sep 2, 2020
## Executing the scripts:

Pre-requisites:
- NetBackup 8.2.1 or higher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- NetBackup 8.2.1 or higher
- NetBackup 8.3 or higher

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the NetBackup version to 8.3

Use the following commands to run the scripts.
### - Single VM backup and restore

This single_vm_backup_restore.py script describes how to backup VM using protection plan and restore the single VMware virtual machine that were backuped with NetBackup for VMware.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This single_vm_backup_restore.py script describes how to backup VM using protection plan and restore the single VMware virtual machine that were backuped with NetBackup for VMware.
This single_vm_backup_restore.py script demonstrates how to backup a VM (VMware virtual machine) using a protection plan and restore it using NetBackup APIs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the description


### - Group VM backup and restore

This group_vm_backup_restore.py script describes how to backup multiple VMs using protection plan and perform bulk restore of VMware virtual machines that were backuped with NetBackup for VMware.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This group_vm_backup_restore.py script describes how to backup multiple VMs using protection plan and perform bulk restore of VMware virtual machines that were backuped with NetBackup for VMware.
This group_vm_backup_restore.py script demonstrates how to backup multiple VMs (VMware virtual machines) using a protection plan and perform bulk restore of the VMs using NetBackup APIs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the description

@jaya-korlepara jaya-korlepara merged commit 648662a into VeritasOS:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants