Skip to content

ansible #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 22, 2020
Merged

ansible #50

merged 7 commits into from
Sep 22, 2020

Conversation

ntbritton
Copy link
Contributor

The start of an ansible snipit section with some tested code against 8.2

Britton, Nicholas added 3 commits December 12, 2019 14:20
inital work posting to github.   looking to work with the community and veritas on the ansible deployments.    msdp_create and vmware_resourcelimits need some assitance.   although it looks right from the swagger docs, it seems to through an api error.
updated body yaml to correct syntax.
Updated to one call
kenogden
kenogden previously approved these changes May 29, 2020
Copy link
Contributor

@kenogden kenogden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and since this has been sitting without comment since Dec'2019, someone should go ahead and approve this merge.

ntbritton added 3 commits June 5, 2020 15:07
vmware asset groups post for vmware filter based on folders.
an example of how we are doing a slo post.
new file added for vmware asset-groups
@ntbritton
Copy link
Contributor Author

Added two more files.

Copy link
Collaborator

@rkennedy rkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a little polish, but it looks good on the whole.

@@ -0,0 +1,25 @@
### NetBackup API Code Samples for Ansible
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start headings at level 1 instead of level 3, please.

Suggested change
### NetBackup API Code Samples for Ansible
# NetBackup API Code Samples for Ansible

#### Pre-requisites:

- NetBackup 8.1.1 or higher
- ansible 2.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize proper nouns.

Suggested change
- ansible 2.x
- Ansible 2.x

Comment on lines +19 to +21
tasks:
-name: name of tasks
include_task: tasklocation/taskname
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark for display as code, and make it valid YAML syntax.

Suggested change
tasks:
-name: name of tasks
include_task: tasklocation/taskname
```yaml
tasks:
- name: name of tasks
include_task: tasklocation/taskname
\```

Comment on lines +15 to +19
register: login

- name: set facts
set_fact:
login_token: "{{login.json.token}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some plays use login_token, and others use login.json.token directly. What's the difference?

Comment on lines +24 to +25
Vars for ansible are defined in a inventory file for use in plays
vars created during plays are used in future ones like login.yml.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown renders this as one sentence. And passive voice makes it unclear whose responsibility it is to perform the actions described here.

Suggested change
Vars for ansible are defined in a inventory file for use in plays
vars created during plays are used in future ones like login.yml.
Define variables for Ansible in an inventory file for use in plays.
Variables registered during plays like login.yaml are used in subsequent plays.

@rkennedy rkennedy merged commit 509508e into VeritasOS:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants