Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed copying Packages folder and replaced it with symlinking #63

Closed
wants to merge 2 commits into from

Conversation

brogan89
Copy link

@brogan89 brogan89 commented Nov 8, 2021

Fixes Bug #57

@brogan89
Copy link
Author

brogan89 commented Nov 8, 2021

Satisfies feature request #58

@mikz
Copy link

mikz commented Jan 25, 2022

This was revered in f3a9c52 because of #23

Probably better to double down on 1646510 rather than going back. Unity does not really like that folder symlinked.

Or can you confirm that is no longer the case?

@brogan89
Copy link
Author

This was revered in f3a9c52 because of #23

Interesting. I"ve never experienced that issue.

Or can you confirm that is no longer the case?

I can only confirm for the version of Unity that I'm using which is the tech stream 2021.2.8 and a few patch versions before that. I've been using my fork of the project for the last few months and it's been fine, no issues updating packages.

@mikz
Copy link

mikz commented Jan 25, 2022

Well, it was not really problem about updating packages. But Unity showed a window "Resolving packages" for a few seconds whenever you changed focus between windows or when some script was changed. That was quite annoying.

@mikz
Copy link

mikz commented Jan 25, 2022

I tried it with 2021.1.28 and I can't reproduce #23 but entirely new issue appears.
If I open two Rider windows it starts consuming 100% CPU and overriding each other's packages.

I think this behaviour should be configurable as depending on the workflow it might cause issues.

@314pies
Copy link
Contributor

314pies commented Feb 4, 2022

Hi folks!

Thanks for bringing this up; Will take a deeper look when available.

@mikz
Copy link

mikz commented Feb 4, 2022

Maybe just a button in menu to force the sync would be ok too. You don't change packages very often.

@fangjunzhou
Copy link

Maybe just a button in menu to force the sync would be ok too. You don't change packages very often.

I've added a preference checkbox to let users decide whether to sync Package, I'm not sure if that helps. Latter I will try to add another feature to force sync the Package folder. I still think this is important. At least for me, I changed package directory very often.

@kamyker
Copy link

kamyker commented Jan 19, 2023

I tried it with 2021.1.28 and I can't reproduce #23 but entirely new issue appears. If I open two Rider windows it starts consuming 100% CPU and overriding each other's packages.

I think this behaviour should be configurable as depending on the workflow it might cause issues.

No issues for me in Unity 2023, imo Package symlinking should be on by default.

@RunninglVlan
Copy link

README is also confusing - it tells that Packages are symlinked, when in fact they're just copied

@314pies 314pies deleted the branch VeriorPies:develop May 15, 2024 02:54
@314pies 314pies closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants