Fix verifier cleanup composition, stream/xml disposal and comparison#1771
Merged
SimonCropp merged 2 commits intoJul 5, 2026
Merged
Conversation
- Compose async cleanups with a Then helper so both are awaited; `+=` on a Func<Task> builds a multicast delegate that only awaits the last target, so converter/user async cleanups were fire-and-forget - Run cleanup in a finally around HandleResults so it still runs when the comparison throws - IsAutoVerify: only gate the global autoVerify delegate on typeName, so the per-settings delegate works for the file-level InnerVerifier(directory, name) - VerifyXml(Stream) disposes the stream, matching the other stream APIs - Comparer.Text reads the verified file with VerifierSettings.Encoding so a BOM-less non-UTF8 UseEncoding round-trips (writes already use it) - StreamComparer rents its buffers from ArrayPool and compares exactly the bytes read via SequenceEqual (a rented buffer's trailing bytes are arbitrary) - Add tests for the above
SimonCropp
deleted the
Fix-verifier-cleanup-composition,-stream/xml-disposal-and-comparison
branch
This was referenced Jul 6, 2026
Closed
Open
Open
Closed
This was referenced Jul 7, 2026
Bump Argon, DiffEngine, EmptyFiles and Verify
NServiceBusCommunity/NServiceBus.Community.Serilog#864
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.