Fix combination runner/converter, Expecto directory verification, and…#1769
Merged
SimonCropp merged 2 commits intoJul 5, 2026
Conversation
… clipboard accept - CombinationRunner: validate every input list is non-empty in the constructor with a descriptive message instead of a raw IndexOutOfRangeException - CombinationRunner: pass the raw method result to after-callbacks; only the serialized CombinationResult is wrapped in InfoBuilder when recording is active - CombinationResultsConverter: cache GetNameForParameter per distinct key value instead of recomputing it for every cell (O(distinct) instead of O(rows*keys)) - Verify.Expecto: the VerifyDirectory(DirectoryInfo) overloads now capture GetCallingAssembly and call the core directly, so the caller's assembly is used rather than Verify.Expecto - Verify.Expecto: use ExceptionDispatchInfo to rethrow the inner exception so the original stack trace is preserved - ClipboardAccept: parse Verify_DisableClipboard leniently (1/0/yes/no/on/off/ true/false) and warn instead of throwing from the static constructor, which poisoned the type with a TypeInitializationException - ClipboardAccept: shell-escape substituted paths so metacharacters ($, `) in a path are not expanded - Add tests for the above
This was referenced Jul 6, 2026
Closed
Open
Open
Closed
This was referenced Jul 7, 2026
Bump Argon, DiffEngine, EmptyFiles and Verify
NServiceBusCommunity/NServiceBus.Community.Serilog#864
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… clipboard accept